You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replaces the <img> tag in the Loader component with a <div> using a CSS mask, and drives the color from theme.colors.primary600 instead of a hardcoded hex value in the SVG.
Why is it needed?
The loader SVG had fill="#4945FF" hardcoded. Because it was loaded via an <img> tag, CSS could not override it — making the loader ignore custom themes and always render blue.
How to test it?
Open the Storybook Components -> Loader -> custom theme color story. The spinner renders in red, confirming it picks up the theme's primary600 value. With the old code it would still be purple.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Replaces the
<img>tag in the Loader component with a<div>using a CSS mask, and drives the color fromtheme.colors.primary600instead of a hardcoded hex value in the SVG.Why is it needed?
The loader SVG had
fill="#4945FF"hardcoded. Because it was loaded via an<img>tag, CSS could not override it — making the loader ignore custom themes and always render blue.How to test it?
Open the Storybook
Components->Loader->custom theme colorstory. The spinner renders in red, confirming it picks up the theme'sprimary600value. With the old code it would still be purple.Related issue(s)/PR(s)
Fixes #2000